Skip to content

fix: feed bloc query and add activities #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2022
Merged

fix: feed bloc query and add activities #207

merged 3 commits into from
Feb 28, 2022

Conversation

HayesGordon
Copy link
Contributor

  • Fixes adding to a fix lengthed list
  • Changes the init behavior of queryEnrichedActivities (to allow it to be called again)

@codecov
Copy link

codecov bot commented Feb 28, 2022 •
edited
Loading

Codecov Report

Merging #207 (bc6f5b6) into master (90789df) will not change coverage.
The diff coverage is 100.00%.

❗ Current head bc6f5b6 differs from pull request most recent head 858766c. Consider uploading reports for the commit 858766c to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #207   +/-   ##
=======================================
  Coverage   76.94%   76.94%           
=======================================
  Files         139      139           
  Lines        4646     4646           
=======================================
  Hits         3575     3575           
  Misses       1071     1071
Impacted Files Coverage Δ
packages/faye_dart/lib/src/subscription.dart 76.92% <ø> (ø)
...es/stream_feed/lib/src/client/aggregated_feed.dart 94.28% <ø> (ø)
...ream_feed/lib/src/client/image_storage_client.dart 91.30% <ø> (ø)
...s/stream_feed/lib/src/client/reactions_client.dart 91.17% <ø> (ø)
...stream_feed/lib/src/client/stream_feed_client.dart 100.00% <ø> (ø)
...m_feed/lib/src/client/stream_feed_client_impl.dart 86.62% <ø> (ø)
...ckages/stream_feed/lib/src/core/api/batch_api.dart 1.49% <ø> (ø)
...es/stream_feed/lib/src/core/api/reactions_api.dart 96.82% <ø> (ø)
...eam_feed/lib/src/core/http/stream_http_client.dart 71.21% <ø> (ø)
...ages/stream_feed/lib/src/core/models/reaction.dart 97.22% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd139b0...858766c. Read the comment docs.

@sachaarbonel sachaarbonel merged commit cb2e051 into master Feb 28, 2022
@sachaarbonel sachaarbonel deleted the fix/adding-and-fetching-activities branch February 28, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HayesGordon @sachaarbonel