Skip to content

Commit 2267493

Browse files
authored
feat(remix): Add more missing @sentry/node re-exports (getsentry#10391)
Missed some exports in my manual pass in getsentry#10385. Test in getsentry#10389 discovered more missing exports which this PR adds or marks as unnecessary in the re-export test.
1 parent 07a2264 commit 2267493

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ const NODE_EXPORTS_IGNORE = [
2222
'DebugSession',
2323
'AnrIntegrationOptions',
2424
'LocalVariablesIntegrationOptions',
25-
// deprecated
26-
'spanStatusfromHttpCode',
2725
];
2826

2927
type Dependent = {
@@ -43,13 +41,10 @@ const DEPENDENTS: Dependent[] = [
4341
// Next.js doesn't require explicit exports, so we can just merge top level and `default` exports:
4442
// @ts-expect-error: `default` is not in the type definition but it's defined
4543
exports: Object.keys({ ...SentryNextJs, ...SentryNextJs.default }),
46-
ignoreExports: ['withSentryConfig'],
4744
},
4845
{
4946
package: '@sentry/remix',
5047
exports: Object.keys(SentryRemix),
51-
// TODO: Fix exports in remix
52-
skip: true,
5348
},
5449
{
5550
package: '@sentry/serverless',
@@ -58,9 +53,9 @@ const DEPENDENTS: Dependent[] = [
5853
// Deprecated, no need to add this now to serverless
5954
'extractTraceparentData',
6055
'getModuleFromFilename',
56+
'enableAnrDetection',
6157
// TODO: Should these be exported from serverless?
6258
'cron',
63-
'enableAnrDetection',
6459
'runWithAsyncContext',
6560
'hapiErrorPlugin',
6661
],

packages/remix/src/index.server.ts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ export {
3939
// eslint-disable-next-line deprecation/deprecation
4040
makeMain,
4141
setCurrentClient,
42+
NodeClient,
4243
Scope,
4344
// eslint-disable-next-line deprecation/deprecation
4445
startTransaction,
@@ -83,6 +84,18 @@ export {
8384
isInitialized,
8485
cron,
8586
parameterize,
87+
metrics,
88+
// eslint-disable-next-line deprecation/deprecation
89+
getModuleFromFilename,
90+
createGetModuleFromFilename,
91+
functionToStringIntegration,
92+
hapiErrorPlugin,
93+
inboundFiltersIntegration,
94+
linkedErrorsIntegration,
95+
requestDataIntegration,
96+
runWithAsyncContext,
97+
// eslint-disable-next-line deprecation/deprecation
98+
enableAnrDetection,
8699
} from '@sentry/node';
87100

88101
// Keeping the `*` exports for backwards compatibility and types

0 commit comments

Comments
 (0)