Skip to content

feat(remix): Add more missing @sentry/node re-exports #10391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2024
Merged

feat(remix): Add more missing @sentry/node re-exports #10391

merged 2 commits into from
Jan 30, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 29, 2024 •
edited
Loading

Missed some exports in my manual pass in #10385. Test in #10389 discovered more missing exports which this PR adds or marks as unnecessary in the re-export test.

@Lms24 Lms24 changed the base branch from develop to lms/test-e2e-node-exports-test January 29, 2024 13:20
@Lms24 Lms24 changed the title feat(remix): Add more missing re-exports from @sentry/node feat(remix): Add more missing @sentry/node re-exports Jan 29, 2024
Base automatically changed from lms/test-e2e-node-exports-test to develop January 29, 2024 14:57
@Lms24 Lms24 force-pushed the lms/feat-remix-export-missing-functions-ii branch from 78f030c to ab9cfbc Compare January 29, 2024 16:02
@Lms24 Lms24 marked this pull request as ready for review January 29, 2024 16:03
@Lms24 Lms24 requested review from lforst and AbhiPrasad January 29, 2024 16:03
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.1 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.32 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.2 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.94 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.34 KB (-0.13% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.23 KB (-0.14% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (+0.01% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (+0.01% 🔺)
@sentry/browser - Webpack (gzipped) 22.6 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.88 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.44 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.32 KB (-0.15% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.51 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.52 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.53 KB (-0.04% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.44 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.4 KB (-0.18% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.71 KB (-0.08% 🔽)
@sentry/react - Webpack (gzipped) 22.63 KB (-0.02% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.38 KB (-0.05% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.69 KB (-0.08% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (-0.04% 🔽)

@Lms24 Lms24 merged commit 2267493 into develop Jan 30, 2024
@Lms24 Lms24 deleted the lms/feat-remix-export-missing-functions-ii branch January 30, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lms24 @AbhiPrasad