Fixes uncaught RuntimeException 'Property "xyz" does not exist #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatal error: Uncaught exception 'Gitlab\Exception\RuntimeException' with message 'Property "iid" does not exist for Gitlab\Model\MergeRequest object' in lib\Gitlab\Model\AbstractModel.php:50
|
There would be no point in using the |
|
I actually would expect that when new properties are added to Gitlab, that the API client shouldn't break, but ignore new properties. This would avoid having to update the API client everytime the API changes. |
|
Hmmm... you are right. |
m4tthumphrey
added a commit
that referenced
this pull request
Oct 28, 2013
Fixes uncaught RuntimeException 'Property "xyz" does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fatal error: Uncaught exception 'Gitlab\Exception\RuntimeException' with message 'Property "iid" does not exist for Gitlab\Model\MergeRequest object' in lib\Gitlab\Model\AbstractModel.php:50
New properties have been added in some Gitlab API models, for example "iid" for merge requests.
This change should make php-gitlab-api more flexible when new properties are added in Gitlab.