add params id fork #269
add params id fork #269
Conversation
|
I want to use namespace in fork project api ,so I added params in it。 |
lib/Gitlab/Api/Projects.php
Outdated
| @@ -498,9 +498,9 @@ public function removeLabel($project_id, $name) | |||
| * @param int $project_id | |||
| * @return mixed | |||
| */ | |||
| public function fork($project_id) | |||
| public function fork($project_id, array $params) | |||
There was a problem hiding this comment.
The options parameter should be optional
fork default value
lib/Gitlab/Api/Projects.php
Outdated
| { | ||
| return $this->post('projects/'.$this->encodePath($project_id).'/fork'); | ||
| return $this->post('projects/'.$this->encodePath($project_id).'/fork', $params); |
There was a problem hiding this comment.
Could you add $params validation using OptionResolver?
There was a problem hiding this comment.
I don't know how to use;
There was a problem hiding this comment.
Here is an example of how to use OptionResolver for a post request: https://github.com/m4tthumphrey/php-gitlab-api/blob/032b7cca7b376686522d00bcb404bc9167a6e0c4/lib/Gitlab/Api/RepositoryFiles.php#L35-L68.
|
So,can you merge my pull requests? |
lib/Gitlab/Api/Projects.php
Outdated
| { | ||
| return $this->post('projects/'.$this->encodePath($project_id).'/fork'); | ||
| return $this->post('projects/'.$this->encodePath($project_id).'/fork', $params); |
lib/Gitlab/Api/Projects.php
Outdated
| { | ||
| return $this->post('projects/'.$this->encodePath($project_id).'/fork'); | ||
| return $this->post($this->getProjectPath($project_id, 'fork'), $params); |
There was a problem hiding this comment.
Please, use the OptionResolver to add input data validation.
use the OptionResolver
|
I have finished it. |
lib/Gitlab/Api/Projects.php
Outdated
| * @return mixed | ||
| */ | ||
| public function fork($project_id) | ||
| public function fork($project_id, array $params = array()) |
There was a problem hiding this comment.
Could you use $parameters for consistency with other methods in this library?
lib/Gitlab/Api/Projects.php
Outdated
| { | ||
| return $this->post('projects/'.$this->encodePath($project_id).'/fork'); | ||
| $resolver = $this->createOptionsResolver(); |
There was a problem hiding this comment.
You can use $this->createOptionsResolver() here as this methods returns an OptionsResolver preconfigured for pagination. Here a new OptionsResolver() will do the job.
There was a problem hiding this comment.
It looks like you missed this one ;)
|
sorry,I didn't find it。 |
|
The |
use `$resolver = new OptionsResolver();`
|
Thank you! |
add params id fork