Better connection exception reporting and small changes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h to avoid time zone calculations
…h to avoid time zone calculations
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
===========================================
- Coverage 79.25% 58.67% -20.58%
===========================================
Files 71 72 +1
Lines 988 1014 +26
Branches 229 237 +8
===========================================
- Hits 783 595 -188
- Misses 67 326 +259
+ Partials 138 93 -45
Continue to review full report at Codecov.
|
GoodforGod
reviewed
Oct 10, 2020
| @@ -1,8 +1,9 @@ | |||
| # java-etherscan-api | |||
|
|
|||
|  | |||
| [](https://travis-ci.com/iSnow/java-etherscan-api) | |||
There was a problem hiding this comment.
I think that this should be linked to https://jitpack.io/#goodforgod/java-etherscan-api as other links too
GoodforGod
reviewed
Oct 10, 2020
| throw new ParseException(e.getMessage(), e.getCause()); | ||
| if (e instanceof JsonSyntaxException) { | ||
| Map<String, Object> map = gson.fromJson(json, Map.class); | ||
| Object statusCode = map.get("status"); |
There was a problem hiding this comment.
What is the point to check for status & message if you only consider result field in the end?
GoodforGod
reviewed
Oct 10, 2020
| @@ -7,8 +7,14 @@ | |||
| * @since 29.10.2018 | |||
| */ | |||
| public class ParseException extends ApiException { | |||
| String json; | |||
|
Hello and thanks for PR and improvements! |
|
It looks easier for me to merge and change all myself. |
|
Partly merged via cherry pick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added
Also fixed the Travis link on the README.md