feat: Add execution id logging to uniquely identify request logs #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30c88e8 to
17e84cf
Compare
akerekes
reviewed
Feb 12, 2025
invoker/core/src/main/java/com/google/cloud/functions/invoker/gcf/ExecutionIdUtil.java
Outdated
Show resolved
Hide resolved
invoker/core/src/main/java/com/google/cloud/functions/invoker/gcf/JsonLogHandler.java
Show resolved
Hide resolved
invoker/core/src/main/java/com/google/cloud/functions/invoker/HttpFunctionExecutor.java
Show resolved
Hide resolved
invoker/core/src/main/java/com/google/cloud/functions/invoker/BackgroundFunctionExecutor.java
Outdated
Show resolved
Hide resolved
invoker/core/src/main/java/com/google/cloud/functions/invoker/gcf/JsonLogHandler.java
Outdated
Show resolved
Hide resolved
Adds an execution id for each http. When the LOG_EXECUTION_ID env var is set, the execution id is added as a new field to the json logs.
17e84cf to
53a3e26
Compare
akerekes
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an execution id for each http. When the LOG_EXECUTION_ID env var is set, the execution id is added as a new field to the json logs.
Additional testing was completed by deploying a container generated with BuildPacks to an existing Gen2 GCF function and verifying updated logging.