Skip to content

docs: add ts example #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 12, 2020
Merged

docs: add ts example #192

merged 7 commits into from
Aug 12, 2020

Conversation

naseemkullah
Copy link
Contributor

@naseemkullah naseemkullah commented Aug 9, 2020 •
edited
Loading

Also lints README by indenting some codeblocks in enumerated lists.

@google-cla google-cla bot added the cla: yes label Aug 9, 2020
@naseemkullah naseemkullah force-pushed the ts-example branch 2 times, most recently from 57039e7 to 9ddc513 Compare August 9, 2020 15:21
docs: add ts example
2f55c11 
Signed-off-by: Naseem <naseem@transit.app>
@grant grant self-requested a review August 10, 2020 03:12
grant
grant suggested changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the guide! Some requested changes:

  • Can you brush up the instructions such that they can be copy-paste-able? I think there are some missing steps.
  • It might be worth adding a link to this comment: #13 (comment)
    • That extra feature of tsc-watch would be really useful.

docs: simplify instructions, leverage tsc-watch for development
e068d55 
Signed-off-by: Naseem <naseem@transit.app>
@naseemkullah naseemkullah requested a review from grant August 10, 2020 04:09
naseemkullah
naseemkullah commented Aug 10, 2020
View reviewed changes
@naseemkullah
Copy link
Contributor Author

Thanks for the guide! Some requested changes:

  • Can you brush up the instructions such that they can be copy-paste-able? I think there are some missing steps.

  • It might be worth adding a link to this comment: #13 (comment)

    • That extra feature of tsc-watch would be really useful.

Thanks for the feedback @grant, ready for another review at this point.

grant
grant reviewed Aug 10, 2020
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through this doc and ran into an issue with the new tsc-watch part. Specifically, I did not see the function refreshing when code was updated. 😢

I found a solution that I think we should use. 😸 Can we add that? Below has the exact script.

Once that's in, I'll approve and merge. Thanks for your patience!

Naseem and others added 3 commits August 10, 2020 09:17
fix: use Title Casing for title
63df9a2 
Signed-off-by: Naseem <naseem@transit.app>
fix: improve readbility and copy pasteability
7d3d4a4 
Signed-off-by: Naseem <naseem@transit.app>
@naseemkullah
Merge branch 'master' into ts-example
2060a75
@grant
Copy link
Contributor

grant commented Aug 11, 2020

@naseemkullah Ping me when this is ready for review. I think the only thing is the tsc-watch part.

@naseemkullah
Copy link
Contributor Author

@naseemkullah Ping me when this is ready for review. I think the only thing is the tsc-watch part.

Perfect, thanks @grant, should have it fixed up soon.

adapt watch script to use nodemon and concurrently
84ca4e2 
Signed-off-by: Naseem <naseem@transit.app>
@naseemkullah naseemkullah requested a review from grant August 12, 2020 03:37
grant
grant approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the instructions work when testing locally.

Thanks for the PR! Merging.

@grant grant merged commit 391ebfa into GoogleCloudPlatform:master Aug 12, 2020
@naseemkullah naseemkullah deleted the ts-example branch August 12, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@grant grant grant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naseemkullah @grant