Skip to content

fix: fix cloudevent signature callbacks #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

fix: fix cloudevent signature callbacks #234

merged 1 commit into from
Nov 9, 2020

Conversation

grant
Copy link
Contributor

@grant grant commented Nov 9, 2020

Fixes CloudEvent signature with callbacks.

(cloudevent, callback) =>

@grant
fix: fix cloudevent signature callbacks
6280a53 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant requested a review from hdp617 November 9, 2020 19:52
@grant grant self-assigned this Nov 9, 2020
@google-cla google-cla bot added the cla: yes label Nov 9, 2020
@grant grant merged commit 2449956 into master Nov 9, 2020
@grant grant deleted the grant_cloudevent_callback branch November 9, 2020 20:45
@mattmoor mattmoor mentioned this pull request Nov 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hdp617 hdp617 hdp617 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@grant grant

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grant @hdp617