Skip to content

ci: enable eslint for tests #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2021
Merged

ci: enable eslint for tests #275

merged 1 commit into from
Apr 21, 2021

Conversation

grant
Copy link
Contributor

@grant grant commented Apr 21, 2021

  • Enables linting for tests (they were ignored before for some reason)
  • Note: Almost all of the changes are generated from npm run fix

@grant
ci: enable eslint for tests
59c2f52 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant requested a review from matthewrobertson April 21, 2021 17:41
@grant grant self-assigned this Apr 21, 2021
@google-cla google-cla bot added the cla: yes label Apr 21, 2021
@grant grant mentioned this pull request Apr 21, 2021
Closed
matthewrobertson
matthewrobertson approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@matthewrobertson matthewrobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grant grant merged commit 0bfe7c6 into master Apr 21, 2021
@grant grant deleted the grant_eslint_ban branch April 21, 2021 18:44
@matthewrobertson matthewrobertson mentioned this pull request May 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewrobertson matthewrobertson matthewrobertson approved these changes

Assignees

@grant grant

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grant @matthewrobertson