Skip to content

feat: updates event and cloudevent interfaces #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 21, 2021
Merged

feat: updates event and cloudevent interfaces #276

merged 4 commits into from
Apr 21, 2021

Conversation

grant
Copy link
Contributor

@grant grant commented Apr 21, 2021

  • Updates the function interfaces for the Node FF
    • Adds a LegacyEvent interface
    • Updates CloudEvent interface to CE 1.0 (must have been <1.0 with schemaurl)

@grant
feat: updates event and cloudevent interfaces
3d12c24 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant requested a review from matthewrobertson April 21, 2021 17:50
@grant grant self-assigned this Apr 21, 2021
@google-cla google-cla bot added the cla: yes label Apr 21, 2021
@grant grant mentioned this pull request Apr 21, 2021
Closed
matthewrobertson
matthewrobertson reviewed Apr 21, 2021
View reviewed changes
matthewrobertson
matthewrobertson reviewed Apr 21, 2021
View reviewed changes
matthewrobertson
matthewrobertson approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@matthewrobertson matthewrobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

grant and others added 3 commits April 21, 2021 15:20
@grant
ci: fix interface assertion
affd10f 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant
ci: run npm run fix
7b1eb54 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant
Merge branch 'master' into grant_cloudfunctions_interfaces
f1b6f38
@grant grant added the automerge Summon MOG for automerging label Apr 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit f67d11d into master Apr 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Apr 21, 2021
@grant grant deleted the grant_cloudfunctions_interfaces branch April 21, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewrobertson matthewrobertson matthewrobertson approved these changes

Assignees

@grant grant

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grant @matthewrobertson