Skip to content

Implement CloudEvent to legacy event conversion #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2021

Conversation

matthewrobertson
Copy link
Member

This commit adds middleware that converts known GCP CloudEvent requests to the equivalent legacy context/data event schema. This enables functions using the EVENT signature type to consume events from a source the publishes CloudEvents.

@google-cla google-cla bot added the cla: yes label May 8, 2021
@matthewrobertson matthewrobertson force-pushed the ce-to-legacy-event branch 4 times, most recently from 59f12bd to 59da0b7 Compare May 10, 2021 16:50
@grant
Copy link
Contributor

grant commented May 10, 2021

Nice!

- no re-export
- switch statement
- shorhand object props
- dot member expressions
@matthewrobertson matthewrobertson merged commit 0dc3fd7 into master May 10, 2021
matthewrobertson added a commit that referenced this pull request Jun 3, 2021
matthewrobertson added a commit that referenced this pull request Jun 4, 2021
* Revert "Convert legacy GCF events to CloudEvents (#285)"

This reverts commit d6cabe7.

* Revert "Implement CloudEvent to legacy event conversion (#283)"

This reverts commit 0dc3fd7.
@grant grant deleted the ce-to-legacy-event branch October 15, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants