Skip to content

Update README #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update README #319

wants to merge 1 commit into from

Conversation

steren
Copy link
Contributor

@steren steren commented Sep 10, 2021

  • Cloud Run on GKE -> Cloud Run for Anthos
  • use source deploy instead of Dockerfile

@steren
Update README:
b87888d 
- Cloud Run on GKE -> Cloud Run for Anthos
- use source deploy instead of Dockerfile
@google-cla google-cla bot added the cla: yes label Sep 10, 2021
grant
grant approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@grant grant left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Can you fix the check error of using a conventional commit? I recommend docs: as the commit prefix.

@steren
Copy link
Contributor Author

steren commented Sep 10, 2021

Does GitHub UI allows me to amend a commit? If not, then it's too much friction to use the git CLI just to edit a title

@grant
Copy link
Contributor

grant commented Sep 10, 2021 •
edited
Loading

Does GitHub UI allows me to amend a commit? If not, then it's too much friction to use the git CLI just to edit a title

The GitHub UI allows you to add a commit message when creating the commit. There is GitHub Desktop and other tools besides the git cli to make this change too.

You can also just make a minor change and make sure add docs: in the commit message.

Sorry, I can't merge a commit that doesn't pass CI. These commits are used in release notes and other tools across Cloud.

@steren steren closed this Sep 10, 2021
@steren
Copy link
Contributor Author

steren commented Sep 10, 2021

#320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@grant grant grant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@steren steren

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steren @grant