Skip to content

fix(deps): Move @types/express to dependencies #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2022
Merged

fix(deps): Move @types/express to dependencies #457

merged 2 commits into from
Apr 22, 2022

Conversation

koistya
Copy link
Contributor

@koistya koistya commented Apr 20, 2022 •
edited
Loading

Otherwise, req, res vars have no members in VSCode auto-complete (other than req.rawBody).

Reference https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

grant
grant approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@grant grant merged commit 1682e07 into GoogleCloudPlatform:master Apr 22, 2022
@release-please release-please bot mentioned this pull request Apr 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@grant grant grant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koistya @grant