Skip to content

Add FF config defaults #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 22, 2020
Merged

Add FF config defaults #19

merged 9 commits into from
Jan 22, 2020

Conversation

grant
Copy link
Contributor

@grant grant commented Jan 8, 2020 •
edited
Loading

Adds defaults for FUNCTION_TARGET and FUNCTION_SIGNATURE_TYPE.

This was detected when following the generic FF Docker guide and seeing errors when these env vars were not included.

@grant grant changed the title fixes #18 add config defaults Add FF config defaults Jan 8, 2020
@grant grant self-assigned this Jan 8, 2020
@grant grant requested a review from bshaffer January 8, 2020 10:09
bshaffer
bshaffer reviewed Jan 8, 2020
View reviewed changes
@bshaffer
Copy link
Collaborator

bshaffer commented Jan 8, 2020

Also we should update the table in README.md to reflect the new defaults

bshaffer
bshaffer requested changes Jan 8, 2020
View reviewed changes
@grant
Copy link
Contributor Author

grant commented Jan 15, 2020

@bshaffer Thanks for the comments. PTAL again.

@bshaffer bshaffer force-pushed the grant_default_config branch from 98a20af to 8022a92 Compare January 22, 2020 20:13
@bshaffer bshaffer merged commit 4322de1 into master Jan 22, 2020
@bshaffer bshaffer deleted the grant_default_config branch January 22, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees

@grant grant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grant @bshaffer