adds CloudEvent helloworld to examples, README, and tests #55
Conversation
README.md
Outdated
| The Functions Framework can unmarshall incoming [CloudEvents][cloud-events] | ||
| payloads to a `cloudevent` object. This will be passed as arguments to your | ||
| function when it receives a request. Note that your function must use the | ||
| cloudevent-style function signature: |
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "require": { | |||
| "google/cloud-functions-framework": "^0.3" | |||
| "google/cloud-functions-framework": "dev-master as 0.6.0" | |||
There was a problem hiding this comment.
Is this downloading the latest code available directly from GitHub? (i.e. disabling version pinning)
(This is a beta version, so I'm willing to allow it for now - but we definitely shouldn't do this once we release publicly.)
There was a problem hiding this comment.
it's only for testing. I will change it back once a version is tagged
| @@ -15,10 +15,30 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| /** | |||
| * To use this, set the following environment variables: | |||
There was a problem hiding this comment.
Nit: can these also be specified as command-line args?
There was a problem hiding this comment.
there is no CLI for php at the moment
| } | ||
|
|
||
| public static function tearDownAfterClass(): void | ||
| { | ||
| // If a test failed before it could delete its container |
There was a problem hiding this comment.
Nit: would it be better to have a single "clean up test resources" comment?
(Or maybe even delete these comments outright, if you're of the "code should be self-documenting" philosophy.)
No description provided.