Add Deploy #63
Add Deploy #63
Conversation
|
I think I want @elibixby to do the review but he is prob busy with OSCON, maybe just merge this next week. |
| items: | ||
| - key: startup-script | ||
| value: | | ||
| {% for line in imports['startup-script'].split('\n') %} |
There was a problem hiding this comment.
weird. Can't you just put in the entire value here?
There was a problem hiding this comment.
I could carefully put the entire script, but I want to import it from our existing one. I wish I could still just dump the imported variable but dm team told me this the only way to get the whitespace rendered correctly
There was a problem hiding this comment.
ಠ_ಠ
You could try to use jinja's indent filter, maybe something like
{{imports['startup-script']|indent(10)}}
There was a problem hiding this comment.
I based this based on what the dm team told but I'll give yours a shot out of curiosity
There was a problem hiding this comment.
Don't sweat it too much if it doesn't work.
|
I'd like to see more comments as to why each resource is needed and how it fits in with the deployment. But overall, i'm +1 on this change. |
|
I mostly took the comments from your deploy.sh script into here with some minor edits. Let me try your suggested yaml change. |
This is alternative to deploy.sh Not sure if I also want to create Pub/Sub topics etc. Docs will come next.
|
@waprin Done with my talk, so I can review this now. |
| portName: http | ||
| backends: | ||
| - group: $(ref.{{ NAME }}-frontend-group.instanceGroup) | ||
| zone: {{ properties['zone'] }} |
There was a problem hiding this comment.
One of the big benefits of L7 load balancing on GCE is that you can load balance across multiple regions. In my template I create IGMs for each zone in a list of zones, which might be cool to demonstrate here.... Otherwise I would say just use L3 since the urlmap is trivial.
There was a problem hiding this comment.
Cool, I know you did that for the globally available one, as a starting point I was pretty much porting the gcloud deploy script but I'll look into it.
|
@jonparrott image family support for instance templates wont get added anytime soon. Even now with gcloud, gcloud is actually just pulling down the latest image for a family and creating the instance template with that. Trying to escalate it as a feature but wondering if we can merge this in the meantime. |
|
Fine with me. On Thu, Jun 2, 2016, 11:20 AM Bill Prin notifications@github.com wrote:
|
This is alternative to deploy.sh
Not sure if I also want to create Pub/Sub
topics etc.
Docs will come next.