Skip to content

chore: disable global blunderbuss assignments #10099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Conversation

briandorsey
Copy link
Member

@briandorsey briandorsey commented May 29, 2025

Description

Disabling global blunderbuss assignments (the backup assignments after label based triage).

Context reference: b/421202292

Checklist

  • Please merge this PR for me once it is approved

@briandorsey briandorsey requested review from yoshi-approver and a team as code owners May 29, 2025 18:39
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 29, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @briandorsey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini here, providing a summary of this pull request. This PR, authored by briandorsey, aims to disable the global fallback assignments for issues and pull requests within the Blunderbuss configuration. Currently, if the label-based assignment rules don't match, Blunderbuss defaults to assigning to the GoogleCloudPlatform/java-samples-reviewers team. This change removes that default behavior, relying solely on the label-based assignments.

Highlights

  • Configuration Update: The primary change is an update to the .github/blunderbuss.yml configuration file.
  • Disable Global Assignments: The configuration for global fallback assignments for both issues (assign_issues) and pull requests (assign_prs) is being removed.

Changelog

  • .github/blunderbuss.yml
    • Removed the assign_issues configuration, which previously assigned issues to GoogleCloudPlatform/java-samples-reviewers when no label-based rule matched (lines 15-16).
    • Removed the assign_prs configuration, which previously assigned pull requests to GoogleCloudPlatform/java-samples-reviewers when no label-based rule matched (lines 103-104).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Config file changed,
Default assignments removed,
Labels rule the day.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to disable global Blunderbuss assignments for issues and pull requests, relying solely on label-based triage. The changes are clear, concise, and directly achieve this goal by removing the assign_issues and assign_prs fallback configurations from the .github/blunderbuss.yml file.

Summary of Findings

  • Configuration Simplification: The PR successfully removes the global fallback assignments for issues and PRs. This simplifies the Blunderbuss configuration and makes label-based assignments the sole mechanism for triage, which aligns with the stated intent.
  • Triage Coverage (Low Severity - Not commented due to review settings): With the removal of global fallback assignees, it's important to ensure that the existing label-based assignment rules (assign_issues_by, assign_prs_by) are comprehensive enough to cover all incoming issues and PRs. If there are items that don't match any labels, they might now go unassigned. This is a process consideration rather than a defect in the code change itself. This point is noted as low severity and therefore not included as a specific review comment per the current review settings.

Merge Readiness

The code changes are straightforward and correctly implement the described functionality of disabling global Blunderbuss assignments. No issues meeting the severity threshold for direct comments (medium, high, critical) were found in the provided diffs.

Assuming the team has assessed the impact of relying solely on label-based triage and confirmed its adequacy, these changes appear ready for merging. As a reviewer, I cannot approve the pull request, but based on the code changes themselves, they are well-executed for the stated purpose. Please ensure any necessary internal discussions regarding triage coverage have taken place before merging.

@glasnt glasnt merged commit a6afe6d into main May 29, 2025
10 checks passed
@glasnt glasnt deleted the briandorsey_blunderbuss branch May 29, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants