Skip to content

fix elliptic curve algorithm identifier (#1010) #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2018
Merged

fix elliptic curve algorithm identifier (#1010) #1011

merged 2 commits into from
Jan 31, 2018

Conversation

FlorianTim
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2018
@lesv lesv requested a review from gguuss January 28, 2018 23:01
lesv
lesv approved these changes Jan 28, 2018
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, but @gguuss or @nnegrey should concur.

@lesv lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2018
gguuss
gguuss approved these changes Jan 30, 2018
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested e2e and it's working with the EC algo type. It was working before but it's working now too, as this matches the docs and I've seen the issue reported before, I'll assume this is the preferred name.

@lesv lesv merged commit eda9f14 into GoogleCloudPlatform:master Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@lesv lesv lesv approved these changes

@gguuss gguuss gguuss approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FlorianTim @lesv @gguuss @googlebot @kokoro-team