Skip to content

Conversation

labadav
Copy link

@labadav labadav commented Feb 9, 2018

Adding doc samples for WebSocket and session affinity support beta release.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 9, 2018
@lesv lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2018
@lesv lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2018
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in /flexible, not /appengine -- poorly named - sorry.

Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL - just fix the parent pom ref, and move to flexible.

<artifactId>websocket</artifactId>
<packaging>war</packaging>

<parent>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parent should be:

  <!--
    The parent pom defines common style checks and testing strategies for our samples.
    Removing or replacing it should not affect the execution of the samples in anyway.
  -->
  <parent>
    <groupId>com.google.cloud.samples</groupId>
    <artifactId>shared-configuration</artifactId>
    <version>1.0.8</version>
  </parent>

@lesv
Copy link
Contributor

lesv commented Feb 22, 2018

ping

@lesv
Copy link
Contributor

lesv commented Mar 2, 2018

Ping again

@labadav
Copy link
Author

labadav commented Mar 13, 2018

Closing this as this needs to be re-done and re-tested. The team will re-submit this later. Thanks!

@labadav labadav closed this Mar 13, 2018
@labadav labadav deleted the java-websockets branch March 13, 2018 21:47
Sita04 pushed a commit that referenced this pull request Feb 7, 2023
🤖 I have created a release *beep* *boop*
---


## [3.7.4](https://togithub.com/googleapis/java-dlp/compare/v3.7.3...v3.7.4) (2022-10-03)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1021](https://togithub.com/googleapis/java-dlp/issues/1021)) ([dc6c270](https://togithub.com/googleapis/java-dlp/commit/dc6c2704358015046b86c193b4b3373f26648855))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants