Remove basePath: "/" #1076
Closed
Remove basePath: "/" #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm updating all the openapi files in the getting-started sample in all the sample repos to remove basePath: "/" Here's the reason from simonz130: From the OpenAPI 2 spec: * basePath: "If it is not included, the API is served directly under the host. The value MUST start with a leading slash (/). " * Paths for methods: "A relative path to an individual endpoint. The field name MUST begin with a slash. The path is appended to the basePath in order to construct the full URL." This OpenAPI getting-started sample have basePath: "/", which (per strict spec interpretation) means all the paths start with double-slashes. (e.g "//v1/shelves" rather than "/v1/shelves"). Removing basepath="/" fixes that.
|
|
@dzlier-gcp Could you fix this for Nancy and the other one? |
|
I'm going to merge this into #1077. |
Shabirmean
pushed a commit
that referenced
this pull request
Nov 17, 2022
…#1076) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.11` -> `2.8.12` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.12`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​2812-httpsgithubcomgoogleapisjava-corecomparev2811v2812-2022-09-14) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.11...v2.8.12) ##### Dependencies - Update dependency com.google.api:gax-bom to v2.19.1 ([#​915](https://togithub.com/googleapis/java-core/issues/915)) ([2647fde](https://togithub.com/googleapis/java-core/commit/2647fdee8e2b168f3364af8e76abfe2903578b29)) - Update dependency com.google.protobuf:protobuf-bom to v3.21.6 ([#​916](https://togithub.com/googleapis/java-core/issues/916)) ([a7db234](https://togithub.com/googleapis/java-core/commit/a7db234800481ffba71d3222542971dbcd212d8e)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5Ny4wIn0=-->
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 17, 2022
…1076) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.5.5` -> `2.5.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.5.6`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​256-httpsgithubcomgoogleapisjava-corecomparev255v256-2022-03-01) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.5.5...v2.5.6) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 18, 2022
…#1076) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.11` -> `2.8.12` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.12`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​2812-httpsgithubcomgoogleapisjava-corecomparev2811v2812-2022-09-14) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.11...v2.8.12) ##### Dependencies - Update dependency com.google.api:gax-bom to v2.19.1 ([#​915](https://togithub.com/googleapis/java-core/issues/915)) ([2647fde](https://togithub.com/googleapis/java-core/commit/2647fdee8e2b168f3364af8e76abfe2903578b29)) - Update dependency com.google.protobuf:protobuf-bom to v3.21.6 ([#​916](https://togithub.com/googleapis/java-core/issues/916)) ([a7db234](https://togithub.com/googleapis/java-core/commit/a7db234800481ffba71d3222542971dbcd212d8e)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5Ny4wIn0=-->
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 18, 2022
…#1076) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.11` -> `2.8.12` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.12`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​2812-httpsgithubcomgoogleapisjava-corecomparev2811v2812-2022-09-14) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.11...v2.8.12) ##### Dependencies - Update dependency com.google.api:gax-bom to v2.19.1 ([#​915](https://togithub.com/googleapis/java-core/issues/915)) ([2647fde](https://togithub.com/googleapis/java-core/commit/2647fdee8e2b168f3364af8e76abfe2903578b29)) - Update dependency com.google.protobuf:protobuf-bom to v3.21.6 ([#​916](https://togithub.com/googleapis/java-core/issues/916)) ([a7db234](https://togithub.com/googleapis/java-core/commit/a7db234800481ffba71d3222542971dbcd212d8e)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5Ny4wIn0=-->
Shabirmean
pushed a commit
that referenced
this pull request
Nov 18, 2022
…1076) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.5.5` -> `2.5.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.5.6`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​256-httpsgithubcomgoogleapisjava-corecomparev255v256-2022-03-01) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.5.5...v2.5.6) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).
anguillanneuf
pushed a commit
that referenced
this pull request
Dec 5, 2022
…#1076) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.11` -> `2.8.12` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.12`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​2812-httpsgithubcomgoogleapisjava-corecomparev2811v2812-2022-09-14) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.11...v2.8.12) ##### Dependencies - Update dependency com.google.api:gax-bom to v2.19.1 ([#​915](https://togithub.com/googleapis/java-core/issues/915)) ([2647fde](https://togithub.com/googleapis/java-core/commit/2647fdee8e2b168f3364af8e76abfe2903578b29)) - Update dependency com.google.protobuf:protobuf-bom to v3.21.6 ([#​916](https://togithub.com/googleapis/java-core/issues/916)) ([a7db234](https://togithub.com/googleapis/java-core/commit/a7db234800481ffba71d3222542971dbcd212d8e)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5Ny4wIn0=-->
anguillanneuf
pushed a commit
that referenced
this pull request
Dec 5, 2022
…1076) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.5.5` -> `2.5.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.5.6`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​256-httpsgithubcomgoogleapisjava-corecomparev255v256-2022-03-01) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.5.5...v2.5.6) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm updating all the openapi files in the getting-started sample in all the sample repos to remove basePath: "/"
Here's the reason from simonz130:
From the OpenAPI 2 spec:
This OpenAPI getting-started sample have basePath: "/", which (per strict spec interpretation) means all the paths start with double-slashes. (e.g "//v1/shelves" rather than "/v1/shelves"). Removing basepath="/" fixes that.