Skip to content

Add tags to CloudSQL samples #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2018
Merged

Add tags to CloudSQL samples #1100

merged 2 commits into from
May 10, 2018

Conversation

kurtisvg
Copy link
Contributor

Add some anchors to allow sections to be linked to in the docs

@kurtisvg kurtisvg requested a review from lesv May 10, 2018 17:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2018
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what we are showing here, but LGTM

@@ -11,5 +11,6 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# [START properties]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like it's actually showing that much. What are you teaching here?

@kurtisvg kurtisvg merged commit 072de41 into master May 10, 2018
@kurtisvg kurtisvg deleted the cloudsql-update branch May 10, 2018 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants