Remove unused dependency region tags and update used region tags #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnegrey
previously approved these changes
Aug 27, 2018
tswast
previously approved these changes
Aug 28, 2018
5e63c84 to
97329cd
Compare
|
I updated my approach with the unused region tags. Rather than deleting them, I gave them names that use the standard globally unique naming conventions, so that we avoid people adding the plain "dependencies" region tag in the future. |
97329cd to
4669400
Compare
tswast
previously approved these changes
Aug 29, 2018
4669400 to
2f10893
Compare
Shabirmean
pushed a commit
that referenced
this pull request
Nov 17, 2022
…1197) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.5` -> `2.8.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.6`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​286-httpsgithubcomgoogleapisjava-corecomparev285v286-2022-08-02) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.5...v2.8.6) ##### Dependencies - update dependency com.google.api:gax-bom to v2.18.7 ([#​890](https://togithub.com/googleapis/java-core/issues/890)) ([c67bed5](https://togithub.com/googleapis/java-core/commit/c67bed5281b458e78780cdd918235b5d073917c7)) - update dependency com.google.code.gson:gson to v2.9.1 ([#​888](https://togithub.com/googleapis/java-core/issues/888)) ([7b799c6](https://togithub.com/googleapis/java-core/commit/7b799c66f4aaf057242e9a231b920e49a7c964e9)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 18, 2022
…1197) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.5` -> `2.8.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.6`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​286-httpsgithubcomgoogleapisjava-corecomparev285v286-2022-08-02) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.5...v2.8.6) ##### Dependencies - update dependency com.google.api:gax-bom to v2.18.7 ([#​890](https://togithub.com/googleapis/java-core/issues/890)) ([c67bed5](https://togithub.com/googleapis/java-core/commit/c67bed5281b458e78780cdd918235b5d073917c7)) - update dependency com.google.code.gson:gson to v2.9.1 ([#​888](https://togithub.com/googleapis/java-core/issues/888)) ([7b799c6](https://togithub.com/googleapis/java-core/commit/7b799c66f4aaf057242e9a231b920e49a7c964e9)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
anguillanneuf
pushed a commit
that referenced
this pull request
Dec 5, 2022
…1197) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.5` -> `2.8.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.6`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​286-httpsgithubcomgoogleapisjava-corecomparev285v286-2022-08-02) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.5...v2.8.6) ##### Dependencies - update dependency com.google.api:gax-bom to v2.18.7 ([#​890](https://togithub.com/googleapis/java-core/issues/890)) ([c67bed5](https://togithub.com/googleapis/java-core/commit/c67bed5281b458e78780cdd918235b5d073917c7)) - update dependency com.google.code.gson:gson to v2.9.1 ([#​888](https://togithub.com/googleapis/java-core/issues/888)) ([7b799c6](https://togithub.com/googleapis/java-core/commit/7b799c66f4aaf057242e9a231b920e49a7c964e9)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal with sample region tags is to have a globally unique tag for each sample. The "dependencies" tag is used throughout the java-docs-samples repo, which goes against best practices. This PR accomplishes the following:
Note that this PR does not include all products, only ones that I am responsible for adding to the sample tracker. Others will be performing this update for the remaining products.