Skip to content

Make the test less flaky #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2018
Merged

Make the test less flaky #1245

merged 1 commit into from
Oct 30, 2018

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Oct 30, 2018

@nnegrey nnegrey requested a review from dzlier-gcp October 30, 2018 17:56
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2018
beccasaurus
beccasaurus reviewed Oct 30, 2018
View reviewed changes
dialogflow/cloud-client/src/test/java/com/example/dialogflow/KnowledgeBaseManagementIT.java
}
// To make the test less flaky, check that half of the texts got a result.
assertThat(answersFound).isGreaterThan(TEXTS.size() / 2);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart 👌

@nnegrey nnegrey merged commit 9e660a1 into master Oct 30, 2018
@nnegrey nnegrey deleted the dialogflow-test branch October 30, 2018 18:21
Shabirmean pushed a commit that referenced this pull request Nov 14, 2022
@nnegrey @chingor13
samples: Make the test less flaky (#1245)
34410b1
@Shabirmean Shabirmean mentioned this pull request Nov 15, 2022
Merged
9 tasks
Shabirmean pushed a commit that referenced this pull request Nov 15, 2022
@nnegrey @Shabirmean
samples: Make the test less flaky (#1245)
e364ac7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzlier-gcp dzlier-gcp dzlier-gcp approved these changes

+1 more reviewer

@beccasaurus beccasaurus beccasaurus left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nnegrey @beccasaurus @dzlier-gcp @googlebot