Skip to content

Fix OpenCensus thread cleanup error and other issues. #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2018
Merged

Fix OpenCensus thread cleanup error and other issues. #1246

merged 1 commit into from
Nov 1, 2018

Conversation

dzlier-gcp
Copy link
Member

OpenCensus rep tried running the sample and had some feedback.

  1. Removed "_4" from metric group name.
  2. Added a print message before thread sleep notifying user why the thread is waiting to complete.
  3. Re-added "cleanupDaemonThreads" flag in pom.xml - without it, the program does not end gracefully.
  4. Removed [example_code] tag, no need for it when we don't separate other sections (like the imports).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2018
@dzlier-gcp dzlier-gcp requested a review from kurtisvg November 1, 2018 20:19
mtabasko
mtabasko reviewed Nov 1, 2018
View reviewed changes
Copy link
Contributor

@mtabasko mtabasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dane, these look good to me. I really can't decide whether I want tags around imports right now, so I'm just gonna let it go for now. We can always revisit later if needed.... thanks!

@dzlier-gcp dzlier-gcp merged commit c02460b into GoogleCloudPlatform:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtabasko mtabasko mtabasko left review comments

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dzlier-gcp @kurtisvg @mtabasko @googlebot