Shut down daemon threads #1247
Merged
Shut down daemon threads #1247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding `-Dexec.cleanupDaemonThreads=false` in `mvn exec:java` fixes `java.lang.IllegalThreadStateException`.
kurtisvg
suggested changes
Nov 2, 2018
pubsub/cloud-client/README.md
Outdated
| @@ -29,25 +29,28 @@ For more samples, see the samples in | |||
|
|
|||
| #### Create a new topic | |||
| ``` | |||
| mvn exec:java -Dexec.mainClass=com.example.pubsub.CreateTopicExample -Dexec.args=my-topic | |||
| mvn exec:java -Dexec.cleanupDaemonThreads=false \ | |||
There was a problem hiding this comment.
The exec.cleanupDaemonThreads and the exec.cleanupDaemonThreads arguments are the same every time, so we should add them to the pom.xml to avoid making our users type them out. Check out how Dane did it here.
There was a problem hiding this comment.
Thanks for the link! I have made some changes in pom.xml accordingly.
kurtisvg
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
-Dexec.cleanupDaemonThreads=falseinmvn exec:javafixesjava.lang.IllegalThreadStateException.Fixes #1239