Skip to content

Update KMS samples to use the GAPIC client #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Update KMS samples to use the GAPIC client #1267

wants to merge 9 commits into from

Conversation

bdhess
Copy link
Contributor

@bdhess bdhess commented Nov 20, 2018

Done in a series of commits to improve reviewability; happy to squash.

We should hold off on merging until we have similar changed ready to go for Golang and Python (and possible NodeJS as well).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 20, 2018
@bdhess
Copy link
Contributor Author

bdhess commented Nov 20, 2018

FYI, @dansanche

@bdhess
Copy link
Contributor Author

bdhess commented Jan 7, 2019

Closing in favor of #1288

@bdhess bdhess closed this Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdhess @googlebot