Skip to content

merging the gateways sample #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 10, 2018
Merged

merging the gateways sample #1295

merged 4 commits into from
Dec 10, 2018

Conversation

munkhuushmgl
Copy link
Contributor

Removed Command Sample, Replaced Gateway Command Sample

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2018
@gguuss gguuss self-requested a review December 10, 2018 20:10
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, make sure that readme code renders correctly in preview and also address the small nits on whitespace and the copy in README and we'll be ready.

[parent README](../README.md).

## Setup
mvn exec:java -Dexec.mainClass="com.example.cloud.iot.examples.DeviceGatewayExample"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sometimes GH flavored markdown does not render without a newline above the code line, make sure it looks good in preview

Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either use

    `thisstyle-codeblock`

...or add a newline before the code on line 26 of the beta README and we should be good to go.

@gguuss gguuss merged commit a1d9d32 into GoogleCloudPlatform:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants