-
Notifications
You must be signed in to change notification settings - Fork 2.9k
merging the gateways sample #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, make sure that readme code renders correctly in preview and also address the small nits on whitespace and the copy in README and we'll be ready.
[parent README](../README.md). | ||
|
||
## Setup | ||
mvn exec:java -Dexec.mainClass="com.example.cloud.iot.examples.DeviceGatewayExample" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sometimes GH flavored markdown does not render without a newline above the code line, make sure it looks good in preview
...api-client/beta-features/manager/src/test/java/com/example/cloud/iot/examples/GatewayIT.java
Show resolved
Hide resolved
...api-client/beta-features/manager/src/test/java/com/example/cloud/iot/examples/GatewayIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either use
`thisstyle-codeblock`
...or add a newline before the code on line 26 of the beta README and we should be good to go.
Removed Command Sample, Replaced Gateway Command Sample