Skip to content

codelab initial push #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 15, 2019
Merged

codelab initial push #1354

merged 6 commits into from
Mar 15, 2019

Conversation

munkhuushmgl
Copy link
Contributor

No description provided.

@munkhuushmgl munkhuushmgl requested a review from a team March 15, 2019 00:00
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2019
@munkhuushmgl munkhuushmgl requested a review from gguuss March 15, 2019 00:00
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, LGTM otherwise.

Co-Authored-By: munkhuushmgl <45373284+munkhuushmgl@users.noreply.github.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 15, 2019
Co-Authored-By: munkhuushmgl <45373284+munkhuushmgl@users.noreply.github.com>
@gguuss
Copy link
Contributor

gguuss commented Mar 15, 2019

@googlebot I signed it!

@kurtisvg
Copy link
Contributor

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@dzlier-gcp should be able to override the status check once it's ready to be merged.

Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gguuss
Copy link
Contributor

gguuss commented Mar 15, 2019

@dzlier-gcp Can you nudge the status check on CLAbot? It got a little confused when I suggested edits.

@gguuss gguuss added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 15, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@gguuss
Copy link
Contributor

gguuss commented Mar 15, 2019

I verified the CLAs for all contributors.

@munkhuushmgl munkhuushmgl merged commit db73e1e into master Mar 15, 2019
@gguuss gguuss deleted the adding-codelab branch March 15, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants