-
Notifications
You must be signed in to change notification settings - Fork 2.9k
codelab initial push #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codelab initial push #1354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, LGTM otherwise.
...pi-client/codelab/manager/src/main/java/com/example/cloud/iot/examples/MqttCommandsDemo.java
Show resolved
Hide resolved
...-client/codelab/manager/src/main/java/com/example/cloud/iot/examples/MqttExampleOptions.java
Outdated
Show resolved
Hide resolved
...odelab/manager/src/main/java/com/example/cloud/iot/examples/RetryHttpInitializerWrapper.java
Outdated
Show resolved
Hide resolved
iot/api-client/codelab/manager/src/test/java/com/example/cloud/iot/examples/ManagerIT.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: munkhuushmgl <45373284+munkhuushmgl@users.noreply.github.com>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
Co-Authored-By: munkhuushmgl <45373284+munkhuushmgl@users.noreply.github.com>
@googlebot I signed it! |
@dzlier-gcp should be able to override the status check once it's ready to be merged. |
iot/api-client/codelab/manager/src/test/java/com/example/cloud/iot/examples/ManagerIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dzlier-gcp Can you nudge the status check on CLAbot? It got a little confused when I suggested edits. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
I verified the CLAs for all contributors. |
No description provided.