Add Oauth2 sample for Java 11 #1383
Conversation
appengine-java11/oauth2/pom.xml
Outdated
| <groupId>com.example.appengine</groupId> | ||
| <artifactId>oauth2-sample</artifactId> | ||
|
|
||
| <!-- <parent> |
There was a problem hiding this comment.
Reminder to uncomment this before merging.
appengine-java11/oauth2/pom.xml
Outdated
|
|
||
| <dependencies> | ||
| <!-- Compile/runtime dependencies --> | ||
| <dependency> |
There was a problem hiding this comment.
A comment around where this can be found / why it's needed would be helpful.
There was a problem hiding this comment.
Same as comment on the other one - please add just a little more context so there is no mistaking where to find that folder.
appengine-java11/oauth2/pom.xml
Outdated
| <groupId>com.google.oauth-client</groupId> | ||
| <artifactId>google-oauth-client</artifactId> | ||
| <version>1.28.0</version> | ||
| <scope>provided</scope> |
There was a problem hiding this comment.
Do these need to be scoped to provided?
There was a problem hiding this comment.
I believe so for the runtime.
There was a problem hiding this comment.
You may want to verify that these are provided by the runtime - Seems weird to me that they would be provided (I would think that would be a potential problem with versioning)
There was a problem hiding this comment.
The user needs to copy the dependencies into ${project.build.directory}/appengine-staging; that folder provides the dependencies to the runtime. This is what I understand from Ludo, but correct me if this is off.
appengine-java11/oauth2/src/main/java/com/example/appengine/OAuth2CallbackServlet.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,27 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| Copyright 2015 Google Inc. | |||
appengine-java11/pom.xml
Outdated
| @@ -0,0 +1,49 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
Don't we need this for the tests to run properly ie parent v child pom?
There was a problem hiding this comment.
No - the update you made to Kokoro finds projects by using the pom's themselves instead of relying on the parent POM.
(If we were still doing it with the parent pom this tests wouldn't trigger anyway because it doesn't list the sub projects as modules and isn't listed in the pom located at root)
appengine-java11/pom.xml
Outdated
| @@ -0,0 +1,49 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
No - the update you made to Kokoro finds projects by using the pom's themselves instead of relying on the parent POM.
(If we were still doing it with the parent pom this tests wouldn't trigger anyway because it doesn't list the sub projects as modules and isn't listed in the pom located at root)
appengine-java11/oauth2/pom.xml
Outdated
| <groupId>com.google.oauth-client</groupId> | ||
| <artifactId>google-oauth-client</artifactId> | ||
| <version>1.28.0</version> | ||
| <scope>provided</scope> |
There was a problem hiding this comment.
You may want to verify that these are provided by the runtime - Seems weird to me that they would be provided (I would think that would be a potential problem with versioning)
appengine-java11/oauth2/pom.xml
Outdated
|
|
||
| <dependencies> | ||
| <!-- Compile/runtime dependencies --> | ||
| <dependency> |
There was a problem hiding this comment.
Same as comment on the other one - please add just a little more context so there is no mistaking where to find that folder.
|
@averikitsch tests on this sample didn't actually run (see the java11 logs) |
| @@ -0,0 +1,7 @@ | |||
| runtime: java11 | |||
There was a problem hiding this comment.
nit: Should probably have a license?
No description provided.