Make the HttpHandler example independent of GAE #1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update example to not reference GAE
lesv
approved these changes
May 10, 2019
| // location = "us-central1"; | ||
| // url = "https://<project-id>.appspot.com/tasks/create"; | ||
| // url = "https://example.com/hellohandler"; |
There was a problem hiding this comment.
You might wish to update the README.md file as well.
|
Hmmm, I thought this was supposed to be a non-GAE sample because it's
included in the documentation for non-GAE HTTP tasks, but now I think we
may just need a totally different sample.
*From: *Les Vogel <notifications@github.com>
*Date: *Fri, May 10, 2019 at 10:13 AM
*To: *GoogleCloudPlatform/java-docs-samples
*Cc: *MaxRossGoogle, Author
*@lesv* approved this pull request.
… ------------------------------
In tasks/src/main/java/com/example/task/CreateHttpTask.java
<#1412 (comment)>
:
> // location = "us-central1";
- // url = "https://<project-id>.appspot.com/tasks/create";
+ // url = "https://example.com/hellohandler";
You might wish to update the README.md file as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1412 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABB2H2B2UDZMS6F7UMZGFNTPUWUMRANCNFSM4HMEUEKA>
.
|
|
@averikitsch Can you take over Max's PR and include any suggestions he has. |
averikitsch
pushed a commit
that referenced
this pull request
Oct 27, 2022
9 tasks
averikitsch
pushed a commit
that referenced
this pull request
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.