Skip to content

Update streaming sample to use non-deprecated method #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2019
Merged

Update streaming sample to use non-deprecated method #1413

merged 2 commits into from
May 13, 2019

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented May 10, 2019

No description provided.

@nnegrey nnegrey requested review from nirupa-kumar, dzlier-gcp and a team May 10, 2019 21:14
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2019
lesv
lesv approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you deleted the pom.xml, but other than that LGTM

@nnegrey
Copy link
Contributor Author

nnegrey commented May 13, 2019

Not completely deleted, just removed a bunch of old profiles for running the samples, but since we removed the main() awhile back, I deleted them.

@nnegrey nnegrey merged commit 57717fd into master May 13, 2019
@nnegrey nnegrey deleted the dialogflow-fix branch May 13, 2019 15:27
Shabirmean pushed a commit that referenced this pull request Nov 14, 2022
@nnegrey @chingor13
samples: Update streaming sample to use non-deprecated method (#1413)
afd3cf7
@Shabirmean Shabirmean mentioned this pull request Nov 15, 2022
Merged
9 tasks
Shabirmean pushed a commit that referenced this pull request Nov 15, 2022
@nnegrey @Shabirmean
samples: Update streaming sample to use non-deprecated method (#1413)
da73918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirupa-kumar nirupa-kumar Awaiting requested review from nirupa-kumar

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

1 more reviewer

@lesv lesv lesv approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnegrey @lesv @googlebot