Skip to content

Java 11 Read Me updates #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2019
Merged

Java 11 Read Me updates #1444

merged 3 commits into from
May 31, 2019

Conversation

averikitsch
Copy link
Contributor

No description provided.

@averikitsch averikitsch requested a review from a team May 31, 2019 19:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 31, 2019
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider suggestions.

@@ -48,6 +48,23 @@ To switch to an Open JDK 11 in a Cloud shell session, you can use:

## Java 11 runtime

The simplest way to deploy to App Engine Java 11 is using an executable [Uber JAR][uber-jar]. App Engine will automatically configure the `entrypoint` to run the JAR file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is [...][...] correct here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when using a variable.

@@ -70,7 +70,7 @@ the provided server is running your application as expected.

- Start the server with your `WAR` file as an argument:
```
mvn exec:java -Dexec.args="<path/to/your/war/file"
mvn exec:java -Dexec.args="path/to/your/war/file"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Dexec.args="target/path.war" perhaps or something that mentions target

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@averikitsch averikitsch merged commit 01edb36 into master May 31, 2019
@averikitsch averikitsch deleted the akitsch-patch branch May 31, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants