asset: add quickstart for Real Time Feed API V1P2Beta1 #1563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtisvg
reviewed
Aug 24, 2019
asset/cloud-client/src/main/java/com/example/asset/CreateFeedExample.java
Outdated
Show resolved
Hide resolved
asset/cloud-client/src/main/java/com/example/asset/CreateFeedExample.java
Outdated
Show resolved
Hide resolved
asset/cloud-client/src/main/java/com/example/asset/CreateFeedExample.java
Show resolved
Hide resolved
asset/cloud-client/src/main/java/com/example/asset/ListFeedsExample.java
Outdated
Show resolved
Hide resolved
asset/cloud-client/src/main/java/com/example/asset/ListFeedsExample.java
Outdated
Show resolved
Hide resolved
|
Thanks, I've updated based on the comments. please take a look. |
kurtisvg
suggested changes
Aug 27, 2019
asset/cloud-client/src/main/java/com/example/asset/CreateFeedExample.java
Outdated
Show resolved
Hide resolved
asset/cloud-client/src/test/java/com/example/asset/RealTimeFeed.java
Outdated
Show resolved
Hide resolved
asset/cloud-client/src/test/java/com/example/asset/RealTimeFeed.java
Outdated
Show resolved
Hide resolved
asset/cloud-client/src/test/java/com/example/asset/RealTimeFeed.java
Outdated
Show resolved
Hide resolved
asset/cloud-client/src/test/java/com/example/asset/RealTimeFeed.java
Outdated
Show resolved
Hide resolved
asset/cloud-client/src/test/java/com/example/asset/RealTimeFeed.java
Outdated
Show resolved
Hide resolved
|
Thanks for another review, updated the PR to address the comments. |
kurtisvg
suggested changes
Aug 28, 2019
kurtisvg
approved these changes
Aug 29, 2019
minherz
pushed a commit
that referenced
this pull request
Nov 16, 2022
* asset: add quickstart for Real Time Feed API V1P2Beta1 * address review comments * refine test * address comments * updated based on comments * fix presubmit error
minherz
pushed a commit
that referenced
this pull request
Nov 17, 2022
* asset: add quickstart for Real Time Feed API V1P2Beta1 * address review comments * refine test * address comments * updated based on comments * fix presubmit error
anguillanneuf
pushed a commit
that referenced
this pull request
Dec 5, 2022
* asset: add quickstart for Real Time Feed API V1P2Beta1 * address review comments * refine test * address comments * updated based on comments * fix presubmit error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud Asset Inventory is launching a series of Beta Apis:
In this PR, we added all the examples.