Skip to content

feat: Adds functions_helloworld_get #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 7, 2019
Merged

feat: Adds functions_helloworld_get #1573

merged 6 commits into from
Sep 7, 2019

Conversation

grant
Copy link
Contributor

@grant grant commented Sep 6, 2019 •
edited
Loading

Adds the basic Hello, World function.

devrel/samples/304

@grant grant requested a review from a team September 6, 2019 20:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 6, 2019
kurtisvg
kurtisvg approved these changes Sep 6, 2019
View reviewed changes
@grant grant merged commit e14f3ba into master Sep 7, 2019
@grant grant deleted the grant_functions_helloworld_get branch September 7, 2019 02:44
@grant
Copy link
Contributor Author

grant commented Sep 7, 2019

Last commits were because of a hiccup in the suggested multiline change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grant @kurtisvg @googlebot