[Cloud Run] System Packages #1610
Conversation
|
This is reliant on graphviz being installed. I need to figure out how to add that to the testing env. |
|
You'll need to either update the kokoro script to install it, or get it inside the container. |
|
Adding it to the container. Will re-run the tests once the testing container has been updated. |
|
@kurtisvg ready for review now |
run/system-package/pom.xml
Outdated
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-shade-plugin</artifactId> |
There was a problem hiding this comment.
Why do we need to shade this package?
There was a problem hiding this comment.
That's how the Spark framework recommends creating an uber-jar in order to run the application.
There was a problem hiding this comment.
Would you recommend not using it?
There was a problem hiding this comment.
It seems odd to me - shading doesn't just add the dependencies, it remaps them all. Usually this is to avoid conflicts between dependencies. Normally, I would expect creating an uber-jar to use something like this.
Look at the SparkJava docs, i don't see anything about creating an uber-jar. The only reference I can find is this tutorial, which doesn't seem to be official documentation.
So it seems like shading might be unnecessary, but I don't know enough about Spark to say definitely.
There was a problem hiding this comment.
Thanks for explaining your thoughts. I've looked more into it and have removed the shade.
* draft * Update comments/linting * Add test and lint * remove print * fix linting * Fix lint * Remove shaded
No description provided.