Add endpoints sample. #248
Conversation
|
@shun-fan @tswast PTAL |
| <version>3.3</version> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <configuration> | ||
| <source>1.7</source> |
There was a problem hiding this comment.
Copied directly from the hello world app.
There was a problem hiding this comment.
Okay. Java 7 is fine. Might as well use it until you need a Java 8 feature.
|
LGTM after adding JavaDoc to the auth info handler. |
|
There's also a problem that this actually doesn't deploy. It needs additional support from the gcloud maven plugin. DO NOT SUBMIT yet. |
|
@tswast javadoc done. does it look like the correct phrasing, etc? |
Current coverage is 46.76%@@ master #248 diff @@
==========================================
Files 74 77 +3
Lines 1943 2164 +221
Methods 0 0
Messages 0 0
Branches 137 148 +11
==========================================
- Hits 1102 1012 -90
- Misses 841 1121 +280
- Partials 0 31 +31
|
| @@ -0,0 +1,68 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
There was a problem hiding this comment.
nit. We've been adding license headers to new pom.xml files (has to appear after <?xml ...> line.
Also, the XML attributes to the <project> tag are optional, so we've been leaving them out.
| @@ -0,0 +1,8 @@ | |||
| # Google Cloud Endpoints on App Engine flexible environment | |||
| This sample demonstrates how to use Google Cloud Endpoints on Google App Engine Flexible Environment using Java. | |||
|
|
|||
There was a problem hiding this comment.
Should mention where you need to edit to make this work.
|
I'll revisit this at some point. This now deploys, but doesn't work. The Java runtime and/or Endpoints runtime needs some modification. |
|
@ludoch This is waiting on mvn plugin work. GoogleCloudPlatform/gcloud-maven-plugin#88 |
|
No, it isn't. The maven plugin was updated. |
|
@broady Coverage for unit tests decreases. Add tests? |
| <plugin> | ||
| <groupId>org.eclipse.jetty</groupId> | ||
| <artifactId>jetty-maven-plugin</artifactId> | ||
| <version>9.3.7.v20160115</version> |
|
This is now functional. Java DPEs, I need you to pick up this CL if you want any other modifications. At the moment, it's equivalent to our other samples, suitable for Alpha. |
|
Would still like to see all the comments incorporated, but LGTM for now. |
No description provided.