Skip to content

Bigtable Keyviz Art Codelab #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 22, 2020
Merged

Bigtable Keyviz Art Codelab #2631

merged 9 commits into from
Apr 22, 2020

Conversation

billyjacobson
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 11, 2020
@billyjacobson billyjacobson marked this pull request as ready for review April 13, 2020 15:36
@billyjacobson billyjacobson requested a review from a team April 13, 2020 15:36
lesv
lesv suggested changes Apr 13, 2020
View reviewed changes
@billyjacobson billyjacobson added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 13, 2020
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 13, 2020
lesv
lesv approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pending SME reviews

kolea2
kolea2 reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending my one question

@lesv
Copy link
Contributor

lesv commented Apr 21, 2020

ping @billyjacobson

@billyjacobson billyjacobson merged commit 0057fc9 into master Apr 22, 2020
@billyjacobson billyjacobson deleted the bigtable-keyviz-art branch April 22, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 kolea2 left review comments

@lesv lesv lesv approved these changes

@davidcavazos davidcavazos Awaiting requested review from davidcavazos

Assignees

@lesv lesv

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@billyjacobson @lesv @kolea2 @googlebot @kokoro-team