Skip to content

Update and add new KMS samples #2699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2020
Merged

Update and add new KMS samples #2699

merged 4 commits into from
Apr 22, 2020

Conversation

sethvargo
Copy link
Member

Update Cloud KMS samples to match new standards (one file per sample, remove runnable/cli), and add more asymmetric samples.

@sethvargo sethvargo requested review from kurtisvg and a team April 21, 2020 01:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 21, 2020
@sethvargo sethvargo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 21, 2020
@sethvargo
Copy link
Member Author

The Java 11 issues seem to be related to quota. The default KMS quotas are quite high, so I'm surprised to see that. It didn't happen on Go or C# samples, and C# runs each test in parallel across many more versions.

@kurtisvg could look into the current KMS quota values on the project please?

@lesv
Copy link
Contributor

lesv commented Apr 21, 2020

Looking into it.

@kurtisvg
Copy link
Contributor

@sethvargo I'm seeing a peak of 62 writes per minute. Does that sound high?

@lesv
Copy link
Contributor

lesv commented Apr 21, 2020

Currently 60, hitting 62 writes / min; Requested bump to 120.

kurtisvg
kurtisvg suggested changes Apr 21, 2020
View reviewed changes
bdhess
bdhess approved these changes Apr 21, 2020
View reviewed changes
@sethvargo sethvargo force-pushed the sethvargo/kms_samples branch from 818fd64 to 0998a1a Compare April 21, 2020 19:58
@sethvargo sethvargo requested a review from kurtisvg April 21, 2020 19:59
kurtisvg
kurtisvg approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - there are a few issues raised in Spotbugs, it would be great check if they are relevant or not.

@lesv
Copy link
Contributor

lesv commented Apr 22, 2020

KMS quota is now 120/sec which we are well below.

@sethvargo sethvargo merged commit e3ec44e into master Apr 22, 2020
@sethvargo sethvargo deleted the sethvargo/kms_samples branch April 22, 2020 23:11
@lesv lesv removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv left review comments

@kurtisvg kurtisvg kurtisvg approved these changes

@bdhess bdhess bdhess approved these changes

Assignees

@lesv lesv

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sethvargo @lesv @kurtisvg @bdhess @googlebot