Skip to content

Update Secret Manager samples to be canonical #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

Update Secret Manager samples to be canonical #2717

merged 1 commit into from
Apr 24, 2020

Conversation

sethvargo
Copy link
Member

This updates Secret Manager to use the more canonical helpers and also updates the layout to use the new preferred layout.

@sethvargo sethvargo requested a review from a team April 21, 2020 22:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 21, 2020
@lesv
Copy link
Contributor

lesv commented Apr 21, 2020

@sethvargo You can now merge, or ask us to.

@sethvargo sethvargo merged commit 82c66ef into master Apr 24, 2020
@sethvargo sethvargo deleted the sethvargo/secretmanager-canonical branch April 24, 2020 14:49
@sethvargo
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@stephaniewang526 stephaniewang526

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sethvargo @lesv @googlebot @stephaniewang526