Skip to content

deps: upgrade beam version to 2.20.0 in bigtable and dataflow samples #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2020

Conversation

kolea2
Copy link
Contributor

@kolea2 kolea2 commented May 6, 2020

Opening in favor of #2740

It's a good idea to open an issue first for discussion.

  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass (mvn -P lint clean verify)
    • (Note- Checkstyle passing is required; Spotbugs, ErrorProne, PMD, etc. ERROR's are advisory only)
  • Please merge this PR for me once it is approved.

@kolea2 kolea2 requested a review from a team May 6, 2020 14:31
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2020
@kolea2 kolea2 closed this May 6, 2020
@kolea2 kolea2 reopened this May 6, 2020
@kolea2 kolea2 closed this May 6, 2020
@kolea2 kolea2 reopened this May 6, 2020
@kolea2
Copy link
Contributor Author

kolea2 commented May 6, 2020

CC @billyjacobson @lesv - beam 2.20.0 was bringing in a new version of guava that conflicted with our truth dep, so excluded that in the test dependency. Also cleaned up unnecessary declared deps.

@lesv lesv merged commit 89c728a into GoogleCloudPlatform:master May 6, 2020
@kolea2 kolea2 deleted the deps-beam2.20.0 branch May 6, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants