Skip to content

Functions: clarify cloudbuild.yaml #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2020
Merged

Functions: clarify cloudbuild.yaml #2946

merged 1 commit into from
May 20, 2020

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented May 20, 2020

@ace-n ace-n requested a review from a team May 20, 2020 18:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2020
lesv
lesv approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but function/dir/from/repo/root doesn't appear easy for users to spot and change, especially if it's repeated.

@ace-n
Copy link
Contributor Author

ace-n commented May 20, 2020

@labtopia would it be better if we called this out in the docs?

@labtopia
Copy link

Adding a comment to the docs to clarify sounds like a good idea to me.

@ace-n ace-n merged commit c6901f0 into master May 20, 2020
@ace-n ace-n deleted the ace-n-patch-1 branch May 20, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@lesv lesv

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ace-n @labtopia @lesv @googlebot