Skip to content

Update Springboot apps to use resource file for PORT env var #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2020
Merged

Update Springboot apps to use resource file for PORT env var #3343

merged 1 commit into from
Jul 10, 2020

Conversation

averikitsch
Copy link
Contributor

@averikitsch averikitsch commented Jul 10, 2020 •
edited
Loading

Fixes #3322

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@averikitsch averikitsch requested a review from a team July 10, 2020 22:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2020
@averikitsch averikitsch added the automerge Merge the pull request once unit tests and other checks pass. label Jul 10, 2020
@lesv lesv assigned lesv and unassigned dzlier-gcp Jul 10, 2020
@averikitsch averikitsch merged commit 36f5996 into master Jul 10, 2020
@averikitsch averikitsch deleted the springboot branch July 10, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@lesv lesv

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spring Boot Cloud Run samples should use application properties for port rather
4 participants
@averikitsch @lesv @googlebot @dzlier-gcp