Skip to content

remove unused parameter #3402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2020
Merged

remove unused parameter #3402

merged 2 commits into from
Jul 22, 2020

Conversation

averikitsch
Copy link
Contributor

Fixes #3390

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@averikitsch averikitsch requested a review from a team July 22, 2020 16:33
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2020
@averikitsch averikitsch added the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2020
@lesv
Copy link
Contributor

lesv commented Jul 22, 2020

Didn't pass Java 8 or Java 11.

Java 11

- testing logging/cloud-client
------------------------------------------------------------
[ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 14.002 s <<< FAILURE! - in com.example.logging.LoggingIT
[ERROR] com.example.logging.LoggingIT.testWriteAndListLogs  Time elapsed: 10.895 s  <<< ERROR!
org.junit.runners.model.TestTimedOutException: test timed out after 10000 milliseconds
	at app//com.example.logging.LoggingIT.testWriteAndListLogs(LoggingIT.java:89)

[ERROR] Errors:
[ERROR]   LoggingIT.testWriteAndListLogs:89 » TestTimedOut test timed out after 10000 mi...
[ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0

@averikitsch averikitsch merged commit b75c9aa into master Jul 22, 2020
@averikitsch averikitsch deleted the logging branch July 22, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@dzlier-gcp dzlier-gcp

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logging/cloud-client Nightly failures
3 participants
@averikitsch @lesv @dzlier-gcp