Skip to content

translate sample to use libraries-bom 10.0.0 #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2020
Merged

translate sample to use libraries-bom 10.0.0 #3671

merged 3 commits into from
Sep 8, 2020

Conversation

suztomo
Copy link
Contributor

@suztomo suztomo commented Sep 8, 2020 •
edited
Loading

Fixes #3670

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@suztomo suztomo requested a review from a team September 8, 2020 19:54
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2020
@suztomo
Copy link
Contributor Author

suztomo commented Sep 8, 2020 •
edited
Loading

fb6e9ee failed "Kokoro CI - Static analysis"

Screen Shot 2020-09-08 at 16 16 28

https://source.cloud.google.com/results/invocations/4ff4efa9-77a4-4aaa-86d0-8ca6cfa69e98 says:

#
# translate/cloud-client
#

[ERROR] COMPILATION ERROR :
[ERROR] javac: invalid target release: 11
Usage: javac <options> <source files>
use --help for a list of possible options

@suztomo suztomo mentioned this pull request Sep 8, 2020
Closed
@suztomo
Copy link
Contributor Author

suztomo commented Sep 8, 2020

Created an issue #3672

@lesv lesv merged commit e6b6999 into GoogleCloudPlatform:master Sep 8, 2020
@suztomo
Copy link
Contributor Author

suztomo commented Sep 8, 2020

@lesv Thank you.

@suztomo suztomo deleted the libraries-bom-check branch September 8, 2020 21:05
@suztomo suztomo mentioned this pull request Sep 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@lesv lesv

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

translate/cloud-client/pom.xml to use the latest GCP Libraries BOM
2 participants
@suztomo @lesv