Skip to content

chore(functions/slack): update Slack sample #3689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2020
Merged

chore(functions/slack): update Slack sample #3689

merged 1 commit into from
Sep 10, 2020

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Sep 10, 2020 •
edited
Loading

  • Use URL encoding instead of JSON for incoming (from Slack) requests
  • Fix improperly formatted outgoing (to Slack) JSON response
  • Move to official (and largely identical) Slack API package

cc @jskeet as FYI

@ace-n ace-n requested review from kurtisvg and a team September 10, 2020 00:31
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 10, 2020
@ace-n ace-n assigned kurtisvg and unassigned lesv Sep 10, 2020
@lesv lesv merged commit f721cf2 into master Sep 10, 2020
@lesv lesv deleted the jskeet-slack branch September 10, 2020 00:40
ace-n pushed a commit that referenced this pull request Sep 10, 2020
chore(functions/slack): add back missing package
5e599ca 
Hotfix for erroneous `pom.xml` change in #3689
@ace-n ace-n mentioned this pull request Sep 10, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 10, 2020
chore(functions/slack): add back missing package (#3690)
989c08f 
Hotfix for erroneous `pom.xml` change in #3689 

@lesv please merge **when tests pass** - thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@kurtisvg kurtisvg Awaiting requested review from kurtisvg

Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ace-n @lesv @kurtisvg