Skip to content

Determine pubsub event timestamp correctly in retry-timeout. #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2020
Merged

Determine pubsub event timestamp correctly in retry-timeout. #3770

merged 1 commit into from
Sep 22, 2020

Conversation

eamonnmcmanus
Copy link
Member

In the retry-timeout sample for GCF java11, we should determine
the event timestamp from the Context parameter, not from properties
of the passed-in PubSub object.

Fixes #3734.

@eamonnmcmanus
Determine pubsub event timestamp correctly in retry-timeout.
68cefdb 
In the retry-timeout sample for GCF java11, we should determine
the event timestamp from the Context parameter, not from properties
of the passed-in PubSub object.

Fixes #3734.
@eamonnmcmanus eamonnmcmanus requested review from ace-n and a team September 21, 2020 23:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2020
lesv
lesv suggested changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - shouldn't we explain it to the user?

ace-n
ace-n previously requested changes Sep 22, 2020
View reviewed changes
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 22, 2020
@lesv
Copy link
Contributor

lesv commented Sep 22, 2020

I'm going to dismiss @ace-n review based on @eamonnmcmanus comments. I'd like to see comments, hopefully that will get fixed in the next PR.

@lesv lesv dismissed ace-n’s stale review September 22, 2020 16:45

Based on Éamonn's comments.

@lesv lesv merged commit 5e69573 into master Sep 22, 2020
@lesv lesv deleted the timestamp branch September 22, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n left review comments

@lesv lesv lesv approved these changes

Assignees

@stephaniewang526 stephaniewang526

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java retry timeout should use context.timestamp to test event age
4 participants
@eamonnmcmanus @lesv @ace-n @stephaniewang526