Skip to content

Vulnerability notification example #3931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 12, 2020
Merged

Vulnerability notification example #3931

merged 9 commits into from
Oct 12, 2020

Conversation

saturnism
Copy link
Contributor

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@saturnism saturnism requested a review from a team October 12, 2020 18:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2020
lesv
lesv reviewed Oct 12, 2020
View reviewed changes
lesv
lesv reviewed Oct 12, 2020
View reviewed changes
lesv
lesv suggested changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

lesv
lesv reviewed Oct 12, 2020
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the maven wrapper and the license

@lesv lesv merged commit 65e5669 into GoogleCloudPlatform:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@averikitsch averikitsch

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saturnism @lesv @averikitsch