Skip to content

Add iot team as code owner #4582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2021
Merged

Add iot team as code owner #4582

merged 2 commits into from
Jan 20, 2021

Conversation

gcseh
Copy link
Contributor

@gcseh gcseh commented Jan 20, 2021

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@gcseh gcseh requested review from telpirion, munkhuushmgl and a team January 20, 2021 16:07
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 20, 2021
@gcseh gcseh assigned telpirion and unassigned shubha-rajan Jan 20, 2021
@telpirion telpirion requested a review from chingor13 January 20, 2021 16:40
@lesv lesv merged commit d741fcf into master Jan 20, 2021
@lesv lesv deleted the iot-team branch January 20, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@telpirion telpirion telpirion approved these changes

@munkhuushmgl munkhuushmgl Awaiting requested review from munkhuushmgl

@chingor13 chingor13 Awaiting requested review from chingor13

Assignees

@telpirion telpirion

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gcseh @lesv @telpirion @shubha-rajan