Skip to content

Update compute java sample #5505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2021
Merged

Update compute java sample #5505

merged 2 commits into from
Jun 29, 2021

Conversation

itodotimothy6
Copy link
Contributor

Fixes #5504

  • I have followed Sample Format Guide
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@itodotimothy6 itodotimothy6 requested a review from a team as a code owner June 25, 2021 22:47
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2021
anguillanneuf
anguillanneuf approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@anguillanneuf anguillanneuf merged commit 11eedd1 into GoogleCloudPlatform:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Java Docs Sample Code to account for Region-specific Operation Resources
3 participants
@itodotimothy6 @anguillanneuf @kurtisvg